Skip to content

fix: resolve lint warnings/errors and apply formatting #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danditomaso wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: resolve lint warnings/errors and apply formatting #1024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
939b42e
fix: resolve lint warnings/errors and apply formatting
danditomaso Mar 10, 2026
2e9c935
updating lock file
danditomaso Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
pnpm lint-staged
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Husky hook file is missing a shebang (and the standard Husky wrapper), so Git may fail to execute it (ENOEXEC) and block commits on POSIX systems. Add the usual hook header and ensure the file is executable, e.g. start with a #!/usr/bin/env sh (or #!/bin/sh) line and source .husky/_/husky.sh before running pnpm lint-staged.

Copilot uses AI. Check for mistakes.
6 changes: 1 addition & 5 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
{
"editor.formatOnSave": true,
"editor.codeActionsOnSave": {
"source.fixAll.biome": "explicit"
},
"search.exclude": {
"**/i18n/locales/*-*/**": true
},
"vitest.workspaceConfig": "vitest.config.ts"
}
}
30 changes: 18 additions & 12 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,21 +12,25 @@
"url": "https://github.com/meshtastic/web/issues"
},
"homepage": "https://meshtastic.org",
"simple-git-hooks": {
"pre-commit": "pnpm run check:fix"
"lint-staged": {
"*.{ts,tsx}": [
"oxlint",
"oxfmt"
]
},
"scripts": {
"preinstall": "npx only-allow pnpm",
"lint": "biome lint",
"lint:fix": "biome lint --write",
"format": "biome format",
"format:fix": "biome format . --write",
"check": "biome check",
"check:fix": "biome check --write",
"lint": "oxlint",
"lint:fix": "oxlint --fix",
"format": "oxfmt --check .",
"format:fix": "oxfmt .",
"check": "pnpm lint && pnpm format",
"check:fix": "pnpm lint:fix && pnpm format:fix",
"build:all": "pnpm run --filter '*' build",
"clean:all": "pnpm run --filter '*' clean",
"publish:packages": "pnpm run build --filter 'packages/transport-*'",
"test": "vitest"
"test": "vitest",
"prepare": "husky"
},
"dependencies": {
"@bufbuild/protobuf": "^2.9.0",
Expand All @@ -35,8 +39,11 @@
"tslog": "^4.9.3"
},
"devDependencies": {
"@biomejs/biome": "2.2.4",
"@types/node": "^24.3.1",
"husky": "^9.1.0",
"lint-staged": "^16.0.0",
"oxfmt": "^0.16.0",
"oxlint": "^1.41.0",
"tsdown": "^0.15.0",
"typescript": "^5.9.2",
"vitest": "^3.2.4"
Expand All @@ -46,8 +53,7 @@
"@serialport/bindings-cpp",
"@tailwindcss/oxide",
"core-js",
"esbuild",
"simple-git-hooks"
"esbuild"
]
}
}
Loading
Loading