Draft: ExternalDependency: add get_runtime_paths method#14713
Open
lb90 wants to merge 2 commits intomesonbuild:masterfrom
Open
Draft: ExternalDependency: add get_runtime_paths method#14713lb90 wants to merge 2 commits intomesonbuild:masterfrom
lb90 wants to merge 2 commits intomesonbuild:masterfrom
Conversation
|
This seems like a reasonable solution! And it looks like the same idea could be applied to |
bruchar1
reviewed
Jun 17, 2025
| raise DependencyException(m.format(self.name, not_found, self.version)) | ||
| return | ||
|
|
||
| def get_runtime_paths(self) -> T.Optional[T.List[str]]: |
Member
There was a problem hiding this comment.
You should probably add this to the Dependency class instead, to make mypy happy, and to remove the need to test for existence using hasattr
Member
|
Would it be possible to add a test for this? |
Contributor
Author
|
Sorry for the delay, will get back to this very soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still very draft, but works!
Fixes #14712