utils/universal: make classify_unity_sources generic #15073
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means it can be either `str`, `File`, or `File | str`, which gives us the value of knowing that if the input is T, the output is Dict[Compiler, List[T]]`
bonzini
approved these changes
Oct 2, 2025
eli-schwartz
requested changes
Oct 3, 2025
|
|
||
| def classify_unity_sources(compilers: T.Iterable['Compiler'], sources: T.Sequence['FileOrString']) -> T.Dict['Compiler', T.List['FileOrString']]: | ||
| compsrclist: T.Dict['Compiler', T.List['FileOrString']] = {} | ||
| def classify_unity_sources(compilers: T.Iterable[Compiler], sources: T.Iterable[FileTypes]) -> T.Dict[Compiler, T.List[FileTypes]]: |
There was a problem hiding this comment.
This patch is itself the thing I stated must be destroyed.
There was a problem hiding this comment.
--verbose, you mean that str is T.Iterable[str] just like it is T.Sequence[str]? This approach is still preferrable to yours if changed to have T.List[FileTypes] as the argument:
Suggested change
| def classify_unity_sources(compilers: T.Iterable[Compiler], sources: T.Iterable[FileTypes]) -> T.Dict[Compiler, T.List[FileTypes]]: | |
| def classify_unity_sources(compilers: T.Iterable[Compiler], sources: T.List[FileTypes]) -> T.Dict[Compiler, T.List[FileTypes]]: |
I just checked and it still passes run_mypy. I'm opening a separate PR.
There was a problem hiding this comment.
I already have a PR. :P
The context is #15057 (comment)
There was a problem hiding this comment.
I know but I disagree that Union is the right solution.
Ok, won't open a PR but you can pick it yourself at https://github.com/bonzini/meson/commit/8e072288ffa0bca7e3c338d6ec5ca4588e5e8e0d.patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means it can be either
str,File, orFile | str, which gives us the value of knowing that if the input is T, the output is Dict[Compiler, List[T]]`