Skip to content

cmake: Fix version kwarg being added to static_library targets #15297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RobotLeopard86 wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −5
Open

cmake: Fix version kwarg being added to static_library targets #15297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions mesonbuild/cmake/interpreter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,11 +1182,12 @@ def process_target(tgt: ConverterTarget) -> None:
'objects': [method(x, 'extract_all_objects') for x in objec_libs],
}

# Only set version if we know it
if tgt.version:
tgt_kwargs['version'] = tgt.version
if tgt.soversion:
tgt_kwargs['soversion'] = tgt.soversion
# Only set version if we know it and this is not a static lib
if not tgt_func == 'static_library':
if tgt.version:
tgt_kwargs['version'] = tgt.version
if tgt.soversion:
tgt_kwargs['soversion'] = tgt.soversion

# Only set if installed and only override if it is set
if install_tgt and tgt.install_dir:
Expand Down
Loading