mesondata: fix mypy warnings #15349
Open
mesondata: fix mypy warnings #15349
+12
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
eli-schwartz
requested changes
Dec 5, 2025
Member
Author
|
I think this is a typeshed issue |
dcbaker
force-pushed
the
submit/typesafe-datafile
branch
from
c4d7ade to
95a9311
Compare
Member
Author
|
@eli-schwartz: updated with an ignore because this is a bad warning from a bug in typeshed. |
Member
|
Nice. |
Member
|
Seems to need tweaking. |
Member
Author
|
Yeah, I think we need to have a version check instead of a |
Member
|
IIRC I wrote this and did it this way because a simple version check was wrong -- older versions of python didn't support the good path, and newer versions of python support the good path only when not running from a zipapp install. Trying to remember the details of what the thought process was... |
Mypy is wrong, because typeshed is wrong, this is just fine. We do need to add a version check, because mypy doesn't understand that the code inside the try can fail, and that's fine. The try/except remains, as it is needed for the zipapp case.
dcbaker
force-pushed
the
submit/typesafe-datafile
branch
from
95a9311 to
566d844
Compare
eli-schwartz
reviewed
Dec 9, 2025
| except AttributeError: | ||
| # fall through to python 3.7 compatible code | ||
| pass | ||
| if sys.version_info >= (3, 10): |
Member
There was a problem hiding this comment.
It should be fine with 3.9 too?
Member
There was a problem hiding this comment.
The error in the previous lint run was occurring for 3.7 and 3.8 only -- and it said "files() doesn't exist".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mypy is wrong because typeshed is wrong.