Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Fix the issue that invalid instance name (empty or null) can be created #64

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

zousheng
Copy link

Fix the issue #63

… the 'CREATE' buttong without focusing on any field
zou sheng added 5 commits May 25, 2017 19:49
…nd spaces from front end and rest api request.
…mically once redis is created or deleted, and generate local unique proxy listening port which stores in zk.
…ecific logs, and remove clean_proxy_port func to avoid concurrent read and write map
@dhilipkumars
Copy link
Member

@zousheng Thanks for the PR?

could you run
gofmt
golint
and
go vet
in the code? we could get a cleaner new code.

Also are you using redis-proxy in your project?

@zousheng
Copy link
Author

Sure, I tried to use it in our production, and found few issues

  1. I changed the proxy part to support proxy multiple redis servers, and store the mappings in the zk. In production the broken pipe issue occurred, and I added one io try catch for io.copy() method. and add the test-on-borrow on client, then it seems solved for now

  2. In test environment, we tried to shutdown machine first to test the failover, it turns out master-slave failover not working, it's only working when I stop or kill the container, so this is very critical issue. Haven't checked the code yet. Would you please give some advice? Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants