🐛 increase the timeout when creating and upgrading CAPI controllers #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When starting up CAPI will try to "warm-up" the configured RuntimeExtensions, and fail if any runtime extension Pods are not up.
This should fix the race conditions seen when creating and upgrading CAPI providers.
dkoshkin
requested review from
jimmidyson,
dlipovetsky,
thunderboltsid and
supershal
dkoshkin
changed the title
supershal
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Thank you Dimitri. We went through the code.
-
We need to also increase timeout when invoking clusterctl ApplyUpgrade API call to ensure that it accounts for registry warmup timeout.
-
We will start discussion upstream to improve algorithm for upgrade capi component process.
jimmidyson
reviewed
Oct 1, 2024
| // Jitter is added as a random fraction of the duration multiplied by the jitter factor. | ||
| return wait.Backoff{ | ||
| Duration: 500 * time.Millisecond, | ||
| Factor: 1.5, | ||
| Steps: 10, | ||
| Steps: 14, |
There was a problem hiding this comment.
I wonder if we should tweak Factor to make the max interval size smaller? Perhaps increasing duration and status, but reducing factor could lead to a longer overall timeout but retain better UX with less excessive waiting?
There was a problem hiding this comment.
I though about that too but avoided for now to reduce the risk of introducing another race somewhere else.
thunderboltsid
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is an attempt to fix the race conditions we've been seeing when creating and upgrading CAPI controllers.
There are 2 fixes here:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #