Skip to content

fix: add image tag and ref in istio-helm default configuration #4459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
msdolbey merged 1 commit into from
Feb 9, 2026
Merged

fix: add image tag and ref in istio-helm default configuration #4459

msdolbey merged 1 commit into from
Feb 9, 2026

Conversation

@kshitij-kumar-ngt
Copy link
Contributor

@kshitij-kumar-ngt kshitij-kumar-ngt commented Jan 29, 2026 •
edited
Loading

What problem does this PR solve?:
Adding kubectl image and tag in cm.yaml , since keeping it in chart was causing issues for older branches as tag moved to newer version v1.35.0
Related PR - mesosphere/charts#1634

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 29, 2026
@mesosphere-ci mesosphere-ci added applications/istio-helm ok-to-test Signals mergebot that CI checks are ready to be kicked off update-licenses signals mergebot to update licenses.d2iq.yaml labels Jan 29, 2026
@coveralls
Copy link

coveralls commented Jan 29, 2026

Pull Request Test Coverage Report for Build 21493137371

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 33.945%
Totals Coverage Status
Change from base Build 21473477796: 0.0%
Covered Lines: 111
Relevant Lines: 327
💛 - Coveralls

@kshitij-kumar-ngt kshitij-kumar-ngt mentioned this pull request Jan 30, 2026
Merged
6 tasks
@kshitij-kumar-ngt kshitij-kumar-ngt changed the title fix: add image tag and ref in cm fix: add image tag and ref in istio-helm default configuration Jan 30, 2026
@kshitij-kumar-ngt
Copy link
Contributor Author

kshitij-kumar-ngt commented Feb 9, 2026

Corresponding 2.17 PR has been merged - https://github.com/mesosphere/kommander-applications/pull/4456/changes

msdolbey
msdolbey approved these changes Feb 9, 2026
View reviewed changes
Copy link
Contributor

@msdolbey msdolbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
the new alpine

@msdolbey msdolbey merged commit 4fefb79 into main Feb 9, 2026
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@takirala takirala takirala approved these changes

@msdolbey msdolbey msdolbey approved these changes

@mikolajb mikolajb Awaiting requested review from mikolajb

@rohitkumar0510 rohitkumar0510 Awaiting requested review from rohitkumar0510

Assignees

No one assigned

Labels

applications/istio-helm ok-to-test Signals mergebot that CI checks are ready to be kicked off size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kshitij-kumar-ngt @coveralls @takirala @msdolbey @mesosphere-ci