Update testing infrastructure #609
Conversation
Fixes the flake8 W605 for the tests: test_marathon_lb.py:1175:-359: W605 invalid escape sequence '\ ' test_marathon_lb.py:1922:-110: W605 invalid escape sequence '\ ' test_marathon_lb.py:1922:-90: W605 invalid escape sequence '\ ' test_marathon_lb.py:2835:22: W605 invalid escape sequence '\ ' test_marathon_lb.py:2852:-81: W605 invalid escape sequence '\ ' test_marathon_lb.py:2931:-182: W605 invalid escape sequence '\ ' test_marathon_lb.py:2931:-157: W605 invalid escape sequence '\ '
Fixes the flake8 E605 for the lines: ./config.py:264:34: W605 invalid escape sequence '\ ' ./config.py:592:61: W605 invalid escape sequence '\ ' ./config.py:596:-84: W605 invalid escape sequence '\ '
|
Can one of the admins verify this patch? |
Dockerfile.dcos-e2e
Outdated
| && git -c advice.detachedHead=false \ | ||
| clone --quiet --depth 1 --branch "${DCOS_E2E_VERSION}" \ | ||
| https://github.com/dcos/dcos-e2e.git /usr/src/dcos-e2e \ | ||
| && pip3 install /usr/src/dcos-e2e \ |
There was a problem hiding this comment.
I'm not aware of an advantage of this over pip3 install git+https://github.com/dcos/dcos-e2e.git@${DCOS_E2E_VERSION}
There was a problem hiding this comment.
git+https urls clone the entire history, during development it was noticeable that it was taking a while to build so I switched it to this. I guess installing from the 'archive' url like in requirements-dev.txt would do the same thing.
There was a problem hiding this comment.
Good to know - another reason to switch to PyPI which I hope I can do sometime.
|
Fixed an issue in the readme, instructing to run |
| DCOS_E2E_DOWNLOAD_SITE := https://downloads.dcos.io/dcos | ||
|
|
||
| ifeq ($(strip $(DCOS_E2E_VARIANT)), enterprise) | ||
| DCOS_E2E_DOWNLOAD_SITE := $(strip \ |
There was a problem hiding this comment.
Please see my DM about this and note here that the issue is acknowledged.
All tests will be run locally in a docker container built/rebuilt on demand. All integration tests will be run locally in a cluster created by DCOS E2E.
Uses a
Makefileto drive testing. Allows locally running unit/integration tests with just docker/curl installed. Includes the two commits from #606. Will close that in favor of this one.