Skip to content

Add Kubernetes deployment guide #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

terrytangyuan
Copy link
Collaborator

@terrytangyuan terrytangyuan commented Jan 29, 2025

This PR moves some content from the recent blog post to here as a more official guide for users who'd like to deploy Llama Stack on Kubernetes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 29, 2025
Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,192 @@
# Kubernetes Deployment Guide
Copy link
Contributor

@ellistarn ellistarn Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an open question to me as to whether or not Kubernetes maps to the Llama Stack "distribution" concept. Many of these steps would not hold true for running w/ meta-reference or ollama. This feels like a sibling of https://github.com/meta-llama/llama-stack/blob/39c34dd25f9365b09000a07de5c46dbdba27e3cb/distributions/remote-vllm/compose.yaml.

However, there is substantial overlap between the compose files for each distribution, so I think we can do better. I think we probably need to figure out how to draw the right boundaries around distributions and deployment options. In the meantime, WDYT about moving this there?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were discussing the same idea on Discord. My initial thought was to first provide a guide so that others can start following similar ways to deploy their selected providers to K8s (and make any necessary changes to meet their needs). Next step is to provide a packaged YAML file that's templated for K8s deployment for each provider (e.g. remote:vllm) and then we can simplify this guide. I believe we'll need a guide anyways to call out specific details.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave this call to the maintainers :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raghotham @ashwinb Any thoughts on this? I think we'll need a guide anyways. In the future, it's a matter of simplifying it once we have K8s distributions in addition to existing docker compose distributions.

@terrytangyuan
Copy link
Collaborator Author

@ellistarn Thanks for the review and suggestions! It's great to cross paths here again

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to get this in for now. I agree with @ellistarn that we need to figure out how Stack distros fit in with K8S in general (I don't believe it is a clear 1:1 map either given so many things that need to happen in a real deployment and I don't know if Stack wants to assert control over them right now.)

@ashwinb ashwinb merged commit 09ed0e9 into meta-llama:main Feb 6, 2025
2 checks passed
@terrytangyuan terrytangyuan deleted the k8s-deployment branch February 6, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants