beautify the handling of mask of None in MMImageMaskInput #1674
+451
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aobo-y
added a commit
to aobo-y/captum
that referenced
this pull request
Nov 25, 2025
…ch#1674) Summary: if `mask` is `None`, the whole `image` is seen as one interpretable feature. Initiate a dummy `mask` whose pixels all belongs to feature id `0`, so the following code can be simplified by assuming `mask` is given Differential Revision: D87890030
Summary: add `MMImageMaskInput`, the most naive interpretable input for image in LLM - only support image features, not text/mixed - only 1 image for now - need a given `mask` for segmentation Differential Revision: D87818563
Summary: add tests for `MMImageMaskInput` Differential Revision: D87822368
…h#1673) Summary: as title Differential Revision: D87877392
…ch#1674) Summary: if `mask` is `None`, the whole `image` is seen as one interpretable feature. Initiate a dummy `mask` whose pixels all belongs to feature id `0`, so the following code can be simplified by assuming `mask` is given Differential Revision: D87890030
aobo-y
force-pushed
the
export-D87890030
branch
from
599b262 to
50b0eed
Compare
Contributor
|
This pull request has been merged in ff0eaf3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: if
maskisNone, the wholeimageis seen as one interpretable feature. Initiate a dummymaskwhose pixels all belongs to feature id0, so the following code can be simplified by assumingmaskis givenDifferential Revision: D87890030