Optim-wip: Miscellaneous Fixes#955
Open
ProGamerGov wants to merge 42 commits intometa-pytorch:optim-wipfrom
Open
Optim-wip: Miscellaneous Fixes#955ProGamerGov wants to merge 42 commits intometa-pytorch:optim-wipfrom
ProGamerGov wants to merge 42 commits intometa-pytorch:optim-wipfrom
Conversation
* Wrap all remaining `torch.__version__` calls in `version.parse`. * Remove unused version check in `typing.py`. * Expose `MaxPool2dRelaxed` to users so that tutorials using it work. * Expose `dataset` module to users. * Fixed `show` & `save_tensor_as_image` docs.
* Update images.py * Update dataset.py * Update images.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
torch.__version__calls inversion.parse.typing.py.MaxPool2dRelaxedto users so that tutorials using it work.datasetmodule to users.show&save_tensor_as_imagedocs.packaginglibrary tosetup.py. While users are likely to already have it installed, there's still a chance that they may not. It's one of the core libraries from the Python Packaging Authority, but it's not included with the base Python installation: https://packaging.python.org/en/latest/key_projects/#pypa-projectsImageTensor.open, withImageTensor.load. Theloadfunction name fits nicer withtorch.load& other PyTorch related functions, so that should improve usability.InputOptimizationdocs & testing coverage.