Skip to content

Conversation

aporialiao
Copy link
Contributor

Summary:

  • DistributedModelParallel: stores sharders passed into planner, this will be reused at resharding
  • Removed hardcoding for module FQNs and plan keys since not compatible with all models. Leveraging how planner/enumerator identifies sharders/EBCs to find the right plan

Differential Revision: D83392188

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 27, 2025
@facebook-github-bot
Copy link
Contributor

@aporialiao has exported this pull request. If you are a Meta employee, you can view the originating diff in D83392188.

@facebook-github-bot
Copy link
Contributor

@aporialiao has exported this pull request. If you are a Meta employee, you can view the originating diff in D83392188.

aporialiao added a commit to aporialiao/torchrec that referenced this pull request Sep 29, 2025
Summary:
Pull Request resolved: meta-pytorch#3398

* `DistributedModelParallel`: stores sharders passed into planner, this will be reused at resharding
* Removed hardcoding for module FQNs and plan keys since not compatible with all models. Leveraging how planner/enumerator identifies sharders/EBCs to find the right plan

Differential Revision: D83392188
@facebook-github-bot
Copy link
Contributor

@aporialiao has exported this pull request. If you are a Meta employee, you can view the originating diff in D83392188.

2 similar comments
@facebook-github-bot
Copy link
Contributor

@aporialiao has exported this pull request. If you are a Meta employee, you can view the originating diff in D83392188.

@facebook-github-bot
Copy link
Contributor

@aporialiao has exported this pull request. If you are a Meta employee, you can view the originating diff in D83392188.

aporialiao added a commit to aporialiao/torchrec that referenced this pull request Sep 29, 2025
Summary:
Pull Request resolved: meta-pytorch#3398

* `DistributedModelParallel`: stores sharders passed into planner, this will be reused at resharding
* Removed hardcoding for module FQNs and plan keys since not compatible with all models. Leveraging how planner/enumerator identifies sharders/EBCs to find the right plan

Differential Revision: D83392188
@facebook-github-bot
Copy link
Contributor

@aporialiao has exported this pull request. If you are a Meta employee, you can view the originating diff in D83392188.

aporialiao added a commit to aporialiao/torchrec that referenced this pull request Sep 29, 2025
Summary:
Pull Request resolved: meta-pytorch#3398

* `DistributedModelParallel`: stores sharders passed into planner, this will be reused at resharding
* Removed hardcoding for module FQNs and plan keys since not compatible with all models. Leveraging how planner/enumerator identifies sharders/EBCs to find the right plan

Differential Revision: D83392188
@facebook-github-bot
Copy link
Contributor

@aporialiao has exported this pull request. If you are a Meta employee, you can view the originating diff in D83392188.

@facebook-github-bot
Copy link
Contributor

@aporialiao has exported this pull request. If you are a Meta employee, you can view the originating diff in D83392188.

aporialiao added a commit to aporialiao/torchrec that referenced this pull request Sep 30, 2025
Summary:
X-link: meta-pytorch#3398

* `DistributedModelParallel`: stores sharders passed into planner, this will be reused at resharding
* Removed hardcoding for module FQNs and plan keys since not compatible with all models. Leveraging how planner/enumerator identifies sharders/EBCs to find the right plan

Differential Revision: D83392188
@facebook-github-bot
Copy link
Contributor

@aporialiao has exported this pull request. If you are a Meta employee, you can view the originating diff in D83392188.

@facebook-github-bot
Copy link
Contributor

@aporialiao has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83392188.

aporialiao added a commit to aporialiao/torchrec that referenced this pull request Sep 30, 2025
Summary:
Pull Request resolved: meta-pytorch#3398

X-link: meta-pytorch#3398

* `DistributedModelParallel`: stores sharders passed into planner, this will be reused at resharding
* Removed hardcoding for module FQNs and plan keys since not compatible with all models. Leveraging how planner/enumerator identifies sharders/EBCs to find the right plan

Differential Revision: D83392188
@facebook-github-bot
Copy link
Contributor

@aporialiao has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83392188.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@aporialiao has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83392188.

aporialiao added a commit to aporialiao/torchrec that referenced this pull request Sep 30, 2025
Summary:
Pull Request resolved: meta-pytorch#3398

X-link: meta-pytorch#3398

* `DistributedModelParallel`: stores sharders passed into planner, this will be reused at resharding
* Removed hardcoding for module FQNs and plan keys since not compatible with all models. Leveraging how planner/enumerator identifies sharders/EBCs to find the right plan

Reviewed By: isururanawaka

Differential Revision: D83392188
@facebook-github-bot
Copy link
Contributor

@aporialiao has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83392188.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@aporialiao has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83392188.

Summary:
Pull Request resolved: meta-pytorch#3398

X-link: meta-pytorch#3398

* `DistributedModelParallel`: stores sharders passed into planner, this will be reused at resharding
* Removed hardcoding for module FQNs and plan keys since not compatible with all models. Leveraging how planner/enumerator identifies sharders/EBCs to find the right plan

Reviewed By: isururanawaka

Differential Revision: D83392188
@facebook-github-bot
Copy link
Contributor

@aporialiao has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83392188.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants