-
Notifications
You must be signed in to change notification settings - Fork 53
Add new metrics for operators #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bdbowyer
wants to merge
1
commit into
meta-pytorch:main
Choose a base branch
from
kernelize-ai:feat/New_Metrics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -157,6 +157,68 @@ def flops( | |
| flops = (2 * m * k * n) + (m * n) | ||
| return flops | ||
|
|
||
| @register_metric() | ||
| def op_gflops( | ||
| self, fn_name: str, example_inputs: Any, metrics: BenchmarkOperatorMetrics | ||
| ) -> float: | ||
| """Report the raw number of GFLOPS (not GFLOPS/sec) for the addmm operation.""" | ||
| _, mat1, mat2 = example_inputs | ||
| m, k = mat1.size() | ||
| k, n = mat2.size() | ||
| flops = (2 * m * k * n) + (m * n) | ||
| # Convert FLOPS to GFLOPS (divide by 10^9) | ||
| gflops = flops / 1e9 | ||
| return gflops | ||
|
|
||
| @register_metric() | ||
| def op_gbytes( | ||
| self, fn_name: str, example_inputs: Any, metrics: BenchmarkOperatorMetrics | ||
| ) -> float: | ||
| """Report the raw number of gigabytes of I/O (not GB/sec) for the addmm operation.""" | ||
| a, mat1, mat2 = example_inputs | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can directly call |
||
| numel = ( | ||
| a.numel() | ||
| + mat1.numel() | ||
| + mat2.numel() | ||
| + (torch.addmm(a, mat1, mat2).numel()) | ||
| ) | ||
| # Convert bytes to gigabytes (divide by 1e9) | ||
| gbytes = numel * a.element_size() / 1e9 | ||
| return gbytes | ||
|
|
||
| @register_metric() | ||
| def grid_size( | ||
| self, fn_name: str, example_inputs: Any, metrics: BenchmarkOperatorMetrics | ||
| ) -> float: | ||
| """Report the total grid size (number of thread blocks) for the addmm operation.""" | ||
| _, mat1, mat2 = example_inputs | ||
| m, k = mat1.size() | ||
| k, n = mat2.size() | ||
|
|
||
| # Automatically ensure best_config is in required_metrics | ||
| if "best_config" not in self.required_metrics: | ||
| self.required_metrics.append("best_config") | ||
|
|
||
| # Return None if best_config is not available (e.g., for baseline implementations) | ||
| if metrics.best_config is None: | ||
| return None | ||
|
|
||
| # Extract actual block sizes from the best configuration | ||
| config = metrics.best_config | ||
| BLOCK_M = config.get("BLOCK_M") | ||
| BLOCK_N = config.get("BLOCK_N") | ||
|
|
||
| # Return None if block sizes are not available in the config | ||
| if BLOCK_M is None or BLOCK_N is None: | ||
| return None | ||
|
|
||
| # Calculate grid size using triton.cdiv for consistency with hstu.py | ||
| grid_m = triton.cdiv(m, BLOCK_M) | ||
| grid_n = triton.cdiv(n, BLOCK_N) | ||
| total_grid_size = grid_m * grid_n | ||
|
|
||
| return float(total_grid_size) | ||
|
|
||
| @register_x_val(label="(M, N, K)") | ||
| def get_x_val(self, example_inputs) -> Tuple[int, int, int]: | ||
| # x-value: computation intensity | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be redundant to the
flops()metric?