Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support major.minor bumps #82

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Support major.minor bumps #82

merged 1 commit into from
Aug 6, 2024

Conversation

crisptrutski
Copy link
Collaborator

Closes #58

I've tested this from the REPL with various temporary commits.

@crisptrutski crisptrutski self-assigned this Jul 31, 2024
@crisptrutski crisptrutski added the developer experience Make developer's lives better label Jul 31, 2024
tsmacdonald
tsmacdonald approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@tsmacdonald tsmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice—best of both worlds (automatic version numbering + sensible version bumps for bigger changes)

@crisptrutski Graphite App
Copy link
Collaborator Author

crisptrutski commented Aug 6, 2024 •
edited
Loading

Merge activity

@crisptrutski crisptrutski merged commit 4c88283 into master Aug 6, 2024
4 checks passed
@crisptrutski crisptrutski deleted the testing-version branch August 6, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmacdonald tsmacdonald tsmacdonald approved these changes

Assignees

@crisptrutski crisptrutski

Labels
developer experience Make developer's lives better .Team/BackendComponents
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement better version numbering
3 participants
@crisptrutski @tsmacdonald @darksciencebase