Skip conversion of contexts into vectors #89
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out there's a big opportunity to expose the scopes directly as Java objects rather than vectors.
I tried instead just interning the conversions, but that turned out quite complex and to still use quite a bit more memory. Since we don't actually use the contexts for anything externally, this seems fine. The API has added some methods to read their properties without interop.
This is a non-breaking change for Metabase.
Before all these context optimizations:
Afterwards (incl previous PR)