Merge pull request #12 from paramsingh/dockerfile-copy-order

BU-8: Copy and install requirements before copying code
metabrainz · Feb 24, 2018 · 8420319 · 8420319
2 parents bdcab5a + c2857b7
commit 8420319
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/test/Dockerfile.py2 b/test/Dockerfile.py2
@@ -12,10 +12,14 @@ RUN apt-get update \
     && apt-get install -y --no-install-recommends \
                        build-essential \
                        git
-COPY . /code/
+
+COPY requirements.txt  /code/requirements.txt
+COPY requirements_dev.txt /code/requirements_dev.txt
 RUN pip install -r requirements.txt
 RUN pip install -r requirements_dev.txt
 
+COPY . /code/
+
 ENV REDIS_HOST "redis"
 
 CMD dockerize -wait tcp://redis:6379 -timeout 10s \

diff --git a/test/Dockerfile.py3 b/test/Dockerfile.py3
@@ -12,10 +12,14 @@ RUN apt-get update \
     && apt-get install -y --no-install-recommends \
                        build-essential \
                        git
-COPY . /code/
+
+COPY requirements.txt  /code/requirements.txt
+COPY requirements_dev.txt /code/requirements_dev.txt
 RUN pip install -r requirements.txt
 RUN pip install -r requirements_dev.txt
 
+COPY . /code/
+
 ENV REDIS_HOST "redis"
 
 CMD dockerize -wait tcp://redis:6379 -timeout 10s \