CB-394: Do not allow CC BY-NC-SA license for future reviews #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amCap1712
reviewed
Oct 11, 2022
amCap1712
reviewed
Oct 11, 2022
| @@ -382,9 +378,6 @@ def edit(id): | |||
| "entity_type": review["entity_type"], | |||
| "review": review, | |||
| } | |||
| if not review["is_draft"]: | |||
There was a problem hiding this comment.
IIUC, this PR currently doesn't show users the option to upgrade from CC SA v3 to CC SA v4. I don't remember whether we decided the move should be opt-in or mandatory but in any case a dialog should be shown to the user. Also, even when doing that need to confirm with @alastair whether CC NC can be upgraded to CC SA or not and accordingly a check may be needed.
Till that is implemented in this or a future PR, we should keep this if check.
There was a problem hiding this comment.
We decided to not worry about asking to upgrade. We'll leave old ones as the current license. If we find that people are asking to upgrade their licenses, the we can add the feature
amCap1712
reviewed
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CB-394
This PR: