Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Player code #2623

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor Player code #2623

wants to merge 2 commits into from
+186 −158

Conversation

zas
Copy link
Collaborator

@zas zas commented Mar 25, 2025

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

  • JIRA ticket (optional): PICARD-XXX

Solution

Action

Additional actions required:

  • Update Picard documentation (please include a reference to this PR)
  • Other (please specify below)

zas added 2 commits March 25, 2025 16:37
@zas
Move playertoolbar.py code to ui/player/__init__.py
853a79b 
- rename it because only class Player is actually exported
@zas
Move Player widgets to their own file (ui/player/widgets.py)
aed3697 
- it simplifies imports and shortens files
@zas zas requested a review from phw March 25, 2025 15:51
@zas
Copy link
Collaborator Author

zas commented Mar 25, 2025

Just splitting code in smaller bits, plus a rename (from playertoolbar to player, for consistency)

@zas zas marked this pull request as ready for review March 25, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phw phw Awaiting requested review from phw

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zas