Skip to content

Commit

Permalink
cleanup: make it pass cargo clippy: for now allow Into without From
Browse files Browse the repository at this point in the history
// allow it, because I am not sure we need it?
// better to explicitly turn into the newtype types
// but i might be wrong
// also for now, allowing it to pass `cargo clippy`
  • Loading branch information
alehander92 committed Aug 29, 2024
1 parent 04a53ce commit 36cb1f7
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 2 deletions.
10 changes: 9 additions & 1 deletion .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,15 @@ env:
CARGO_TERM_COLOR: always

jobs:
build:
lint:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- name: Lint
run: cargo clippy

build-and-test:

runs-on: ubuntu-latest

Expand Down
5 changes: 5 additions & 0 deletions src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
// allow it, because I am not sure we need it?
// better to explicitly turn into the newtype types
// but i might be wrong
// also for now, allowing it to pass `cargo clippy`
#![allow(clippy::from_over_into)]
mod tracer;
mod types;
pub use crate::tracer::{Tracer, NONE_TYPE_ID, NONE_VALUE};
Expand Down
2 changes: 1 addition & 1 deletion src/tracer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ impl Tracer {

pub fn register_step(&mut self, path: &Path, line: Line) {
let path_id = self.ensure_path_id(path);
self.events.push(TraceLowLevelEvent::Step(StepRecord { path_id, line: line }));
self.events.push(TraceLowLevelEvent::Step(StepRecord { path_id, line}));
}

pub fn register_call(&mut self, function_id: FunctionId, args: Vec<FullValueRecord>) {
Expand Down

0 comments on commit 36cb1f7

Please sign in to comment.