Fix dangling IPs in address pool.

metal-stack · Oct 24, 2024 · 62a71fe · 62a71fe
1 parent 5c0d9cd
commit 62a71fe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/pkg/controllers/loadbalancer/config.go b/pkg/controllers/loadbalancer/config.go
@@ -26,15 +26,15 @@ type Config struct {
 }
 
 func (cfg *Config) ComputeAddressPools(ips []*models.V1IPResponse, nws sets.Set[string]) error {
+	cfg.AddressPools = nil
+
 	var errs []error
 	for _, ip := range ips {
 		if !nws.Has(*ip.Networkid) {
 			klog.Infof("skipping ip %q: not part of cluster networks", *ip.Ipaddress)
 			continue
 		}
 
-		klog.Infof("adding ip to pool %s", *ip.Ipaddress)
-
 		net := *ip.Networkid
 		err := cfg.addIPToPool(net, *ip)
 		if err != nil {

diff --git a/pkg/controllers/loadbalancer/metallb/config.go b/pkg/controllers/loadbalancer/metallb/config.go
@@ -5,7 +5,6 @@ import (
 	"fmt"
 	"time"
 
-	"github.com/davecgh/go-spew/spew"
 	"github.com/metal-stack/metal-ccm/pkg/controllers/loadbalancer"
 
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -122,9 +121,6 @@ func (cfg *metalLBConfig) WriteCRs(ctx context.Context, c client.Client) error {
 				AutoAssign: pool.AutoAssign,
 			}
 
-			klog.Info("writing address pool")
-			spew.Dump(ipAddressPool.Spec)
-
 			return nil
 		})
 		if err != nil {