Improve race condition on parallel IP free. #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR should mitigate a possible race condition where ephemeral IP deletion within one cluster can happen when more than one service binds the same IP address. The improvement is to put the IP query call behind the mutex acquisition such that the second call for deletion sees the proper IP tags.
mwennrich
approved these changes
Jul 30, 2024
ulrichSchreiner
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should mitigate a possible race condition where ephemeral IPs are not properly cleaned up within the same cluster. This can happen when more than one service binds the same IP address (e.g. when two services in the same namespace bind the same IP and then the namespace gets deleted).
The improvement is to put the IP query call behind the mutex acquisition such that the second call for deletion sees the proper IP tags.