Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check OIDC token also for regular user access. #51

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Conversation

Gerrit91
Copy link
Contributor

@Gerrit91 Gerrit91 commented Jun 13, 2024

Actually, we can always check for the OIDC token and not only for SSH keys before granting console access. This enhances security.

However, this is a breaking change as clients now have to present the JWT token that they use for accessing the metal-api.

For machine console access, the client now also needs to present the JWT token used for authentication at the metal-api. Update to the latest version of `metalctl` that implements this new behavior.

@Gerrit91 Gerrit91 requested a review from a team as a code owner June 13, 2024 09:28
@Gerrit91 Gerrit91 requested a review from majst01 June 13, 2024 09:29
@majst01 majst01 merged commit 6132dd9 into master Jun 13, 2024
1 check passed
@majst01 majst01 deleted the check-oidc-token branch June 13, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants