Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since gardener node agent, docker is not required anymore #262

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented Nov 8, 2024

Description

All our deployed clusters have gardener node agent instead of cloud-config-downloader. This removes the hard requirement for docker to make bootstrapping possible.

Install containerd only.

Closes: #106

@majst01 majst01 requested a review from a team as a code owner November 8, 2024 06:01
Copy link
Contributor

@robertvolkmann robertvolkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You downgrade containerd from 1.7.22 to 1.6.20 because you switched from containerd.io (Docker repository) to containerd (Debian repository).

Reproduce by:

$ docker run -it debian:bookworm
$ apt update
$ apt install --yes ca-certificates curl gnupg2
$ curl -fLsS https://download.docker.com/linux/debian/gpg | apt-key add -
$ echo "deb [arch=amd64] https://download.docker.com/linux/debian bookworm stable" > /etc/apt/sources.list.d/docker.list
$ apt update
$ apt info containerd
Package: containerd
Version: 1.6.20~ds1-1+b1
$ apt info runc
Package: runc
Version: 1.1.5+ds1-1+deb12u1
$ apt info docker-ce
Package: docker-ce
Version: 5:27.3.1-1~debian.12~bookworm
Priority: optional
Section: admin
Maintainer: Docker <support@docker.com>
Installed-Size: 111 MB
Depends: containerd.io (>= 1.6.24), docker-ce-cli, iptables, libseccomp2 (>= 2.3.0), libc6 (>= 2.34), libsystemd0
Recommends: apparmor, ca-certificates, docker-ce-rootless-extras, git, libltdl7, pigz, procps, xz-utils
Suggests: aufs-tools, cgroupfs-mount | cgroup-lite
$ apt info containerd.io
Package: containerd.io
Version: 1.7.22-1

@robertvolkmann
Copy link
Contributor

Similar situation with Ubuntu:

$ docker run -it ubuntu:24.04
$ apt update
$ apt install --yes ca-certificates curl gnupg2
$ curl -fLsS https://download.docker.com/linux/ubuntu/gpg | apt-key add -
$ echo "deb [arch=amd64] https://download.docker.com/linux/ubuntu noble stable" > /etc/apt/sources.list.d/docker.list
$ apt update
$ apt info containerd
Package: containerd
Version: 1.7.12-0ubuntu4.1
$ apt info runc
Package: runc
Version: 1.1.12-0ubuntu3.1
$ apt info docker-ce
Package: docker-ce
Version: 5:27.3.1-1~ubuntu.24.04~noble
Priority: optional
Section: admin
Maintainer: Docker <support@docker.com>
Installed-Size: 111 MB
Depends: containerd.io (>= 1.6.24), docker-ce-cli, iptables, libseccomp2 (>= 2.3.0), libc6 (>= 2.34), libsystemd0
Recommends: apparmor, ca-certificates, docker-ce-rootless-extras, git, libltdl7, pigz, procps, xz-utils
Suggests: aufs-tools, cgroupfs-mount | cgroup-lite
$ apt info containerd.io
Package: containerd.io
Version: 1.7.22-1

@majst01
Copy link
Contributor Author

majst01 commented Nov 9, 2024

Uuh, nice finding, will fix it thanks

@majst01
Copy link
Contributor Author

majst01 commented Nov 11, 2024

You downgrade containerd from 1.7.22 to 1.6.20 because you switched from containerd.io (Docker repository) to containerd (Debian repository).

Reproduce by:

$ docker run -it debian:bookworm
$ apt update
$ apt install --yes ca-certificates curl gnupg2
$ curl -fLsS https://download.docker.com/linux/debian/gpg | apt-key add -
$ echo "deb [arch=amd64] https://download.docker.com/linux/debian bookworm stable" > /etc/apt/sources.list.d/docker.list
$ apt update
$ apt info containerd
Package: containerd
Version: 1.6.20~ds1-1+b1
$ apt info runc
Package: runc
Version: 1.1.5+ds1-1+deb12u1
$ apt info docker-ce
Package: docker-ce
Version: 5:27.3.1-1~debian.12~bookworm
Priority: optional
Section: admin
Maintainer: Docker <support@docker.com>
Installed-Size: 111 MB
Depends: containerd.io (>= 1.6.24), docker-ce-cli, iptables, libseccomp2 (>= 2.3.0), libc6 (>= 2.34), libsystemd0
Recommends: apparmor, ca-certificates, docker-ce-rootless-extras, git, libltdl7, pigz, procps, xz-utils
Suggests: aufs-tools, cgroupfs-mount | cgroup-lite
$ apt info containerd.io
Package: containerd.io
Version: 1.7.22-1

fixed now:

containerd --version
containerd containerd.io 1.7.22 7f7fdf5fed64eb6a7caf99b3e12efcf9d60e311c

@robertvolkmann robertvolkmann dismissed their stale review November 11, 2024 08:24

Switched to containerd.io

@Gerrit91 Gerrit91 merged commit 4109de9 into master Nov 11, 2024
3 checks passed
@Gerrit91 Gerrit91 deleted the remove-docker branch November 11, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not install docker anymore
3 participants