Move leaf and router role from metal-roles into mini-lab.
#161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertvolkmann
changed the title
leaf and router role from metal-roles into mini-lab.leaf role from metal-roles into mini-lab.
|
Maybe rename the role |
Gerrit91
changed the title
leaf role from metal-roles into mini-lab.leaf and router role from metal-roles into mini-lab.
Comment on lines
+71
to
+79
| - name: render frr configuration | ||
| template: | ||
| src: frr.conf.j2 | ||
| dest: /etc/frr/frr.conf | ||
| validate: '/usr/bin/vtysh --dryrun --inputfile %s' | ||
| tags: frr | ||
| register: frr_rendered | ||
| notify: reload frr | ||
| when: "ansible_facts.services['metal-core.service'] is not defined" |
There was a problem hiding this comment.
Not needed for a leaf
Comment on lines
+43
to
+49
| - name: render interfaces configuration | ||
| template: | ||
| src: interfaces.j2 | ||
| dest: /etc/network/interfaces | ||
| validate: '/sbin/ifup --syntax-check --all --interfaces %s' | ||
| notify: reload interfaces | ||
| when: "ansible_facts.services['metal-core.service'] is not defined" |
There was a problem hiding this comment.
Not needed for a leaf
|
Fails when I apply your requested changes: Please feel free to commit to this pull request directly if you want changes for the switch configuration as I will not be able to judge those. I only moved existing tasks with this PR. |
robertvolkmann
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #155.