Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use metal-toolbox version of flashrom #121

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Use metal-toolbox version of flashrom #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@ RUN microdnf install -y --setopt=tsflags=nodocs --setopt=install_weak_deps=0 \
pciutils \
smartmontools \
tar \
udev \
unzip \
util-linux \
flashrom \
python \
python-devel \
python-pip \
Expand All @@ -86,6 +86,9 @@ RUN microdnf install -y --setopt=tsflags=nodocs --setopt=install_weak_deps=0 \

RUN pip install uefi_firmware==v1.11

# Install our custom flashrom package
ADD https://github.com/metal-toolbox/flashrom/releases/download/v1.3.99/flashrom-1.3.99-0.el9.x86_64.rpm /tmp
RUN rpm -ivh /tmp/flashrom*.rpm
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall back in CentOS that using yum install /path/to/rpm was preferable to using rpm -i... it probably does not matter here, but it is something to think about.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unable to figure out how to get microdnf to install from a local file. Suggestions welcome.


# Delete /tmp/* as we don't need those included in the image.
RUN rm -rf /tmp/*
Expand Down
Loading