Apply fix for gRPC tests as well

metaloom · Feb 2, 2023 · 03f9b51 · 03f9b51
1 parent 2b05dad
commit 03f9b51
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 9 deletions.
diff --git a/common/src/test/java/io/metaloom/qdrant/client/AbstractContainerTest.java b/common/src/test/java/io/metaloom/qdrant/client/AbstractContainerTest.java
@@ -9,4 +9,12 @@ public abstract class AbstractContainerTest {
 	@Rule
 	public QDrantContainer qdrant = new QDrantContainer();
 
+	protected void sleep(int i) {
+		try {
+			Thread.sleep(i);
+		} catch (InterruptedException e) {
+			e.printStackTrace();
+		}
+	}
+
 }
diff --git a/grpc/src/test/java/io/metaloom/qdrant/client/grpc/method/SnapshotGRPCClientTest.java b/grpc/src/test/java/io/metaloom/qdrant/client/grpc/method/SnapshotGRPCClientTest.java
@@ -23,6 +23,8 @@ public void testCreateCollectionSnapshot() throws Exception {
 		createCollection(TEST_COLLECTION_NAME);
 		client.createSnapshot(TEST_COLLECTION_NAME).sync();
 		assertEquals(1, client.listSnapshots(TEST_COLLECTION_NAME).sync().getSnapshotDescriptionsCount());
+		// The snapshot filename is named via seconds. We need to pass some time to allow for creation of another file
+		sleep(2000);
 		client.createSnapshot(TEST_COLLECTION_NAME).sync();
 		assertEquals(2, client.listSnapshots(TEST_COLLECTION_NAME).sync().getSnapshotDescriptionsCount());
 	}

diff --git a/http/src/test/java/io/metaloom/qdrant/client/http/AbstractHTTPClientTest.java b/http/src/test/java/io/metaloom/qdrant/client/http/AbstractHTTPClientTest.java
@@ -76,15 +76,6 @@ protected <T extends RestResponse> T invoke(QDrantClientRequest<T> request) thro
 		}
 	}
 
-	protected void sleep(int i) {
-		try {
-			Thread.sleep(i);
-		} catch (InterruptedException e) {
-			e.printStackTrace();
-		}
-
-	}
-
 	protected void createTestCollection() throws HttpErrorException {
 		CollectionCreateRequest request = new CollectionCreateRequest();
 		request.setVectors(VectorParams.of(4, EUCLID));

diff --git a/http/src/test/java/io/metaloom/qdrant/client/http/method/SnapshotHttpClientTest.java b/http/src/test/java/io/metaloom/qdrant/client/http/method/SnapshotHttpClientTest.java
@@ -108,6 +108,7 @@ public void testCreateStorageSnapshot() throws Exception {
 	public void testListStorageSnapshot() throws Exception {
 		invoke(client.createStorageSnapshot());
 		createCollection(TEST_COLLECTION_NAME);
+		// The snapshot filename is named via seconds. We need to pass some time to allow for creation of another file
 		sleep(2000);
 		invoke(client.createStorageSnapshot());
 		List<SnapshotDescription> snapshots = invoke(client.listStorageSnapshots()).getResult();