Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move find_model_with_retry and use in mpl-core #181

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Conversation

danenbm
Copy link
Contributor

@danenbm danenbm commented Mar 28, 2024

  • Moved find_model_with_retry so now that is a common helper between token metadata and mpl-core program transformers.
    This fixes the erroneous delay logic in the previous mpl-core helper function.
  • Also update to blockbuster 2.2.0 which re-exports mpl-core 0.3.0.
    • The main actual effect of this blockbuster change will be that updateDelegate data will be output as: "data" : { "additional_delegates" : [] } instead of "data" : {},.
    • Other than that wanted to update mpl-core because it was in fact a breaking change and blockbuster re-exports it.
  • Updated integration tests as a couple of the old assets would not deserialize with the breaking change. But I just regenerated all of the mpl-core ones with my scripts so you can see they are all new assets.

@danenbm danenbm marked this pull request as ready for review March 28, 2024 01:42
@danenbm danenbm merged commit 2f5bc5f into main Mar 28, 2024
3 checks passed
@danenbm danenbm deleted the danenbm/fix-loop branch March 28, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants