Update Umi client and add tests for update metadata #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add basic Umi tests * Add proof arg in kinobi and getAssetWithProof test * Add UpdateInstructionsVisitor to auto derive collectionMetadata * Add collection pass and fail test cases
blockiosaurus
approved these changes
Jan 12, 2024
nicholasoxford
pushed a commit
to Primitives-xyz/primitives-protocol
that referenced
this pull request
Jan 16, 2025
…ion#70) * Add basic Umi tests * Add proof arg in kinobi and getAssetWithProof test * Add UpdateInstructionsVisitor to auto derive collectionMetadata * Add collection pass and fail test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
getAssetWithProoftest.UpdateInstructionsVisitorto auto derivecollectionMetadata.Note: This PR is the same as but replaces #69, as that one had too many merge conflicts after I sqash merged update-metadata-staging into main.