Phase 1 - extract model api V2 (wip for Review) DO NOT MERGE#7
Open
Phase 1 - extract model api V2 (wip for Review) DO NOT MERGE#7
Conversation
…r instead of Meteor.users; add unit tests to ensure compatibility when provider is mongo for legacy code
Author
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ModelUserto the more descriptiveAccountsProviderAccountsProvideron the serverAccountsCommonthis.usersfromAccountsProvider(in discussion)user()abstract and implement separately on the client and server.AccountsClient_initConnectiontoAccountsClientthis.userson the client.AccountsProviderinstance when creatingAccountServer(figure out connection management - mongo vs other providers)userscollection from server (TBD)this.accountsProvideron serverthis.userswhenAccountsProvideris mongodb (in discussion)findSingletofindByIdfindCurrentUserandfindSingleLoggedIn, perhaps with expandedfindById(opting for rename vs combine, in consideration of non-mongo providers)insertHLoginTokentoinsertHashedLoginTokenfindUsersInServicesandgetMongoUsersForReactiveWork