Add one more acceptance test for new regridding #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1508 +/- ##
==========================================
- Coverage 97.87% 97.86% -0.01%
==========================================
Files 108 108
Lines 9392 9387 -5
==========================================
- Hits 9192 9187 -5
Misses 200 200
Continue to review full report at Codecov.
|
tjtg
reviewed
Jun 1, 2021
There was a problem hiding this comment.
I think this covers the identified item of having a test to show that the bilinear-2 code produces the same results as the Iris-based bilinear code as identified in #1464.
There's one minor typo I saw when reading through the changes - happy to approve this PR once that's cleaned up.
Co-authored-by: Tom Gale <tom@gale.app>
tjtg
approved these changes
Jun 1, 2021
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
* add one more acceptance test for regridding * change comments in test_regrid * Update improver_tests/acceptance/test_regrid.py Co-authored-by: Tom Gale <tom@gale.app> Co-authored-by: Tom Gale <tom@gale.app>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1464
Description:
Add one more acceptance test for bilinear without land-sea mask awareness , as suggested by Fiona.
The new bilinear-2 regridding option should produce the same result as the original bilinear regridding option.
Therefore, this added test shares the existing kgo.nc with the original bilinear regridding test, and no new acceptance data file is required.
It addressed the last item in #1464.
Testing: