Extendable vector checkers #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug of having the marker in middle of expected
ikitommi
force-pushed
the
extendable-vector-checkers
branch
from
34984f5 to
b2b3e6c
Compare
|
I really like this idea. How ever, now the code base has changed and merging this is not trivial anymore. Also, I would like to use similar approach with other data structures also. Lets think about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of magic marker, vector special checking is now extendable.
also, previous version allowed the
...to be anywhere in the expected vector if it was also in the last position. Like:Also, added CHANGELOG.md & CONTRIBUTING.md