pyroscope-receiver: remove service label from hists #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prometheus histograms are very expensive. This change removes service_name label from histograms, because it can explode cardinality.
|
@tomershafir how would correlation be possible without the service labels? |
|
@lmangani You cant, its a tradeoff. (The other options are: a summery that you cant aggregate, or plain sum and count counters that can yield an average) |
|
@tomershafir added some configurations to filter metrics and labels. Please take a look 1cf5002 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus histograms are very expensive. This change removes service_name label from histograms, because it can explode cardinality.