render_scorecard: fix recent regression in relative path handling #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As aa2cb8f (render_scorecard: move preparation of params to dedicated function, 2024-08-06), a function call instead of an inline list(...) is passed to rmarkdown::render() as the params argument. That change breaks the handling of relative paths for results_dir because render() evaluates the params argument after changing the working directory. Move the function call outside of the rmarkdown::render() call to fix the handling of relative paths.
barrettk
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes breakage that @barrettk noticed when calling our internal
score-r-pkgscript and telling it to use a recent mpn.scorecard commit (a0efd0a). See the first commit's message for details.I threw in the second commit to bump to a dev version. That's something I need for bbi and pkgr. (No plans to tag it unless someone requests it.)