Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight refactor of REG 3 #1248

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Slight refactor of REG 3 #1248

merged 2 commits into from
Oct 15, 2024

Conversation

kylebaron
Copy link
Collaborator

@kylebaron kylebaron commented Oct 12, 2024

This modlib model has never been released. I was looking through the code today, and thought this would be a better pattern to follow if someone picked up the code and wanted to follow. I believe the result is the same from what we had before.

  • Don't initialize in $PREAMBLE
  • Always initialize when starting a new ID (based on NEWIND), but only if REG==3
  • Don't reinitialize every time in $EVENT

@kylebaron kylebaron requested a review from kyleam October 13, 2024 20:37
@kylebaron kylebaron merged commit a231402 into main Oct 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants