Only pass environment into glue #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleam
approved these changes
Oct 23, 2024
| Roxygen: list(markdown = TRUE) | ||
| VignetteBuilder: knitr |
There was a problem hiding this comment.
As far as I understand, dropping this line makes sense because pmtables doesn't carry/package any vignettes under vignettes/. (There are some vignettes, but those are in inst/vignette/, which is not included in the package.)
Merged
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
glue 1.8.0 was recently released and is now insisting that
.envirargument toglue()is really an environment. pmtables was sometimes passing a list. This was always happening through thisgluet()helper I wrote to use<>rather than{}to glue stuff into latex code. This has been fixed now. Also issuing an informative error message in casegluet()ever gets non-environment. And added a regression test specifically forgluet().I also noticed some minor documentation issues that came up, presumably with new roxygen2 version; these also have been addressed in this PR as well.
Reference to changes in glue
https://glue.tidyverse.org/news/index.html#glue-180
tidyverse/glue#308
tidyverse/glue#317
@barrettk @graceannobrien