Skip to content

feat: Explicit error with unsupported files #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krlmlr wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat: Explicit error with unsupported files #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f8db1b
feat: Explicit error with unsupported files
krlmlr Nov 2, 2025
a0a07cb
Fix extension
krlmlr Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion src/duckdb_read_stat.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ void duckdb_read_stat_bind(duckdb_bind_info info)
data->file_format = DUCKDB_READ_STAT_FILE_FORMAT_SAS;
error = readstat_parse_sas7bdat(parser, path, data);
}
if (!strcmp(format, "xpt"))
else if (!strcmp(format, "xpt"))
{
data->file_format = DUCKDB_READ_STAT_FILE_FORMAT_SAS;
error = readstat_parse_xport(parser, path, data);
Expand All @@ -173,6 +173,20 @@ void duckdb_read_stat_bind(duckdb_bind_info info)
data->file_format = DUCKDB_READ_STAT_FILE_FORMAT_STATA;
error = readstat_parse_dta(parser, path, data);
}
else if (!strcmp(format, "sas7bcat"))
{
duckdb_bind_set_error(info, "SAS catalog files (.sas7bcat) are not supported. Only SAS data files (.sas7bdat, .xpt) are supported.");
readstat_parser_free(parser);
duckdb_free(data);
return;
}
else
{
duckdb_bind_set_error(info, "Unsupported format parameter. Supported formats are: sas7bdat, xpt (SAS), sav, zsav, por (SPSS), and dta (Stata).");
readstat_parser_free(parser);
duckdb_free(data);
return;
}
}
else if (duckdb_read_stat_ends_with(path, ".sas7bdat"))
{
Expand All @@ -199,6 +213,20 @@ void duckdb_read_stat_bind(duckdb_bind_info info)
data->file_format = DUCKDB_READ_STAT_FILE_FORMAT_STATA;
error = readstat_parse_dta(parser, path, data);
}
else if (duckdb_read_stat_ends_with(path, ".sas7bcat"))
{
duckdb_bind_set_error(info, "SAS catalog files (.sas7bcat) are not supported. Only SAS data files (.sas7bdat, .xpt) are supported.");
readstat_parser_free(parser);
duckdb_free(data);
return;
}
else
{
duckdb_bind_set_error(info, "Unsupported file extension. Supported formats are: .sas7bdat, .xpt (SAS), .sav, .zsav, .por (SPSS), and .dta (Stata). Specify the format parameter explicitly if the file extension is incorrect.");
readstat_parser_free(parser);
duckdb_free(data);
return;
}

if (error != READSTAT_OK)
{
Expand Down
Loading