Fixed Subclassing Dict Issues (Issue #101) #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when child classes were instantiated, all their nodes -- besides the top node -- remained instances of the parent (Dict) class. Added tests appropriate for these changes. All tests passed. See mewwts#101
|
Hey @MisterVladimir, if the tests pass locally, but not on Travis I think it might be because you run the tests locally like See: Line 8 in 1a9b80b |
Tests can be run with "python setup.py test" instead of manually "python -m test_addict.py".
added 2 commits
August 22, 2018 10:30
Changed "super()" for Python 2.7 compatibility.
Apparently one shouldn't use super(self.__class___, self). All tests now pass with "python setup.py test".
|
Thanks @MisterVladimir! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dictsubclasses' child nodes are now reflect the expected behavior that they're instances of that subclass instead ofDicts. Without this change, daughter nodes of subclass instances raise Attribute or other errors.Added tests appropriate for these changes. 100% of tests passed.
See #101