Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration test: attach a test directory to test file system #61

Merged
merged 3 commits into from
Apr 11, 2024
Merged

integration test: attach a test directory to test file system #61

merged 3 commits into from
Apr 11, 2024

Conversation

saza-ku
Copy link
Contributor

@saza-ku saza-ku commented Apr 9, 2024

To test the file system in the integration test, we need to attach a directory to the VM.

But params.dir_path is overwritten in the current implementation.

This PR fixes so that params.dir_path is correctly set as TEST_DIR_PATH.

@saza-ku saza-ku requested a review from ainozaki April 9, 2024 07:00
@saza-ku saza-ku mentioned this pull request Apr 9, 2024
Closed
ainozaki
ainozaki approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@ainozaki ainozaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@saza-ku saza-ku merged commit 33214ac into mewz-project:main Apr 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ainozaki ainozaki ainozaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saza-ku @ainozaki