Skip to content
This repository has been archived by the owner on Sep 27, 2022. It is now read-only.

Disable dotenv file #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Disable dotenv file #13

wants to merge 3 commits into from

Conversation

nodkz
Copy link
Contributor

@nodkz nodkz commented Nov 19, 2014

I use .rbenv-vars to set up environment variables.
So this patch add ability to disable .env file in repo and use any another file in system with command, for example export $(cat /u/rubygems_proxy/.rbenv-vars | xargs) && cd /u/rubygems_proxy/current && bundle exec rainbows -c rainbows.rb

@nodkz
Copy link
Contributor Author

nodkz commented Nov 19, 2014

Tested on production, works perfectly

@mezis
Copy link
Owner

mezis commented Nov 20, 2014

Dotenv.load! doesn't overwrite already-set environment variabled; so what am I missing?

(also, your avatar is fab ^_^)

@nodkz
Copy link
Contributor Author

nodkz commented Nov 20, 2014

When variable is empty, for example MEMCACHIER_SERVERS="" in my environment, then dotenv override it by its value.

Non-empty values it takes from my environment. I agree with you - I noticed it yesterday, when test my pull request.

So you may decline my pull request.

@mezis
Copy link
Owner

mezis commented Nov 20, 2014

Thanks. I'll leave it open for now as a reminder — this needs to be clarified in the README.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants