-
Notifications
You must be signed in to change notification settings - Fork 7
Add ethereum-sidecar.server.network flag for sidecar
#59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TestingTested with latest mezod
|
docker/mainnet.env.example
Outdated
| MEZOD_HOME="/var/mezod" | ||
| MEZOD_MONIKER="<change me>" | ||
| MEZOD_ETHEREUM_SIDECAR_SERVER_ETHEREUM_NODE_ADDRESS="<change me>" # Ethereum Mainnet WS RPC | ||
| MEZOD_ETHEREUM_SIDECAR_SERVER_NETWORK="<change me>" # Ethereum network (mainnet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is for mainnet, so what about hardcording mainnet value here?
As it is hardcoded for native
docker/testnet.env.example
Outdated
| MEZOD_HOME="/var/mezod" | ||
| MEZOD_MONIKER="<change me>" | ||
| MEZOD_ETHEREUM_SIDECAR_SERVER_ETHEREUM_NODE_ADDRESS="<change me>" | ||
| MEZOD_ETHEREUM_SIDECAR_SERVER_NETWORK="<change_me>" # Ethereum network (testnet - Sepolia) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is for testnet, so what about hardcording sepolia value here?
As it is hardcoded for native
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the network name does not be placed in secret. It's not confidential information.
Actually, we don't need to define any new parametr in values.yaml.
We can add condition to the StatefulSet, as follows:
- --ethereum-sidecar.server.ethereum-node-address=$(ETHEREUM_ENDPOINT)
{{- if eq .Values.env.NETWORK "mainnet" }}
- --ethereum-sidecar.server.network=mainnet
{{- else if eq .Values.env.NETWORK "testnet" }}
- --ethereum-sidecar.server.network=sepolia
{{- end }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or we can add env.MEZOD_ETHEREUM_SIDECAR_SERVER_NETWORK to the values.yaml and use it:
- --ethereum-sidecar.server.network={{ .Values.env.MEZOD_ETHEREUM_SIDECAR_SERVER_NETWORK }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that sounds good, i will adjust it ;)
This is a fix for native validator kit that adds a flag for ethereum sidecar to support different ethereum networks.
Note
Right now the change is in the testing phase.