Skip to content

Conversation

@phuongtrinhviet
Copy link
Collaborator

@phuongtrinhviet phuongtrinhviet commented Dec 8, 2025

Ticket

#361

General

  • No unnecessary files, debug logs, or commented code included.
  • PR has at least 1 peer approval before senior review.
  • I fully understand the code I submitted.
  • No hardcoded configuration or secrets.
  • Environment Variables changes? (Leave unchecked if N/A)

Design & Solution Clarity

  • This is refactor task

Testing

Note: Complex logic must not rely on manual testing only.

Peer Review Checklist

  • I understand the overall solution and flow.
  • The code follows the provided design diagram.
  • No obvious logic or security issues found.
  • Tests are sufficient for the scope of this change.

@phuongtrinhviet phuongtrinhviet changed the title refactor stats update to batch total_blocks increment and remove hot … [indexer] #361 optimize sync block from indexer Dec 10, 2025
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FORCE function outside have get by range
param -> from - to instead of []int

Copy link
Collaborator

@hoangdohuy hoangdohuy Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need check outside this function
I think it all started from getBlockNumbersToCommit and getBlockNumbersToPublish just return from -> to instead of list block number
I Think this is big change but I think it's very useful;
it will reduce the workload of having to create a list block like that.

Copy link
Collaborator

@hoangdohuy hoangdohuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants