-
Notifications
You must be signed in to change notification settings - Fork 0
[indexer] #361 optimize sync block from indexer #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
indexer/internal/rpc/rpc.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FORCE function outside have get by range
param -> from - to instead of []int
indexer/internal/worker/worker.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need check outside this function
I think it all started from getBlockNumbersToCommit and getBlockNumbersToPublish just return from -> to instead of list block number
I Think this is big change but I think it's very useful;
it will reduce the workload of having to create a list block like that.
…partial success.
hoangdohuy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ticket
#361
General
Design & Solution Clarity
Testing
Peer Review Checklist