Skip to content

Conversation

@potatoArthurDo
Copy link
Collaborator

@potatoArthurDo potatoArthurDo commented Dec 29, 2025

#563

General

  • No unnecessary files, debug logs, or commented code included.
  • PR has at least 1 peer approval before senior review.
  • I fully understand the code I submitted.
  • No hardcoded configuration or secrets.
  • Environment Variables changes? (Leave unchecked if N/A)

Design & Solution Clarity

  • A design diagram (sequence / flow) is attached or linked.
  • The implementation matches the design.
  • All major flows and decision points are represented in the diagram.
  • Error handling and edge cases are clearly defined in the design.

Design link (diagram / doc):
<paste link here>

Testing

  • Unit tests cover main logic and important edge cases.

Note: Complex logic must not rely on manual testing only.

image image image

Peer Review Checklist

  • I understand the overall solution and flow.
  • The code follows the provided design diagram.
  • No obvious logic or security issues found.
  • Tests are sufficient for the scope of this change.

@potatoArthurDo potatoArthurDo changed the title [dong][FE][P2P] Cancel Button FE [dong][FE][P2P] Cancel offer API Dec 30, 2025
@potatoArthurDo potatoArthurDo changed the title [dong][FE][P2P] Cancel offer API [dong][FE][P2P] #563 Cancel offer API Dec 30, 2025
Copy link
Collaborator

@hoangdohuy hoangdohuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sontung-ncc sontung-ncc merged commit 478aade into dong-P2P-563 Dec 30, 2025
@sontung-ncc sontung-ncc deleted the dong-p2p-563-FE branch December 30, 2025 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants