Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors from execute() by its returning values #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nandenjin
Copy link
Contributor

@nandenjin nandenjin commented Nov 17, 2020

Fixes #16

This PR fixes error handling of utility.execute(). It does not throw any errors, but returns them as returning values.

Note: I removed some detections with err.err.code === 'ENOENT' because it causes TypeError: Property 'code' does not exist on type 'Error'.ts(2339). At base code err is typed as any so it was not a problem. I'm not sure how to fix it. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors while executing compiler are not caught correctly
1 participant