Fix last line of stream being stuck in buffer #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requests.Response.iter_lines has a known issue where it will not return a line if the bytes in that line is less than the minimum size and it's the last line.
psf/requests#3577
In my case it caused events to only be picked up when the next event came in from the DVR. So the motion event would only register when the next videoloss event came in or some other event.
Basically means the latest event is just never picked up. The second latest event according to the DVR will alway be the last one interpreted by the library.
In real life this caused my motion events to notify my home assistant with considerable lag. Up to 10 seconds.