Skip to content

More flexible parsing options and a stricter default #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

More flexible parsing options and a stricter default #92

wants to merge 1 commit into from

Conversation

eternal-flame-AD
Copy link

@eternal-flame-AD eternal-flame-AD commented Dec 12, 2024 •
edited
Loading

Fixes #80. Fixes #31. Fixes #21. Fixes #11.

Changes:

  • Moved the main parsing function to a more stricter one with a sensible default that should cover the typical usage (web submissions). I left "isEmail" alone as the function name never implied it does any sanitation.
  • Fixed a potential SMTP command injection.

I can't get two tests to pass even without modifications, maybe the email domain used in the test changed their configuration?

@eternal-flame-AD
More flexible parsing options and a stricter default
1c2a429 
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
This was referenced Feb 13, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@eternal-flame-AD