Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change base class of TimeZoneSerializerField from DJRF's Field to CharField #137

Merged
merged 5 commits into from
Jul 7, 2024
Merged

Change base class of TimeZoneSerializerField from DJRF's Field to CharField #137

merged 5 commits into from
Jul 7, 2024

Commits on Jul 7, 2024

  1. Add tests to clarify allow_null behavior

    @mfogel
    mfogel committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    dbe227d View commit details
    Browse the repository at this point in the history

  2. Subclass CharField instead of Field 

    Add tests to ensure allow_null & allow_blank are working as expected
    @mfogel
    mfogel committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    b0de1cf View commit details
    Browse the repository at this point in the history

  3. Add test of required kwarg as well

    @mfogel
    mfogel committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    1a1c207 View commit details
    Browse the repository at this point in the history

  4. Add changelog entry

    @mfogel
    mfogel committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    c895ae9 View commit details
    Browse the repository at this point in the history

  5. Make the linter happy

    @mfogel
    mfogel committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    610a2c2 View commit details
    Browse the repository at this point in the history