This repository was archived by the owner on Jul 17, 2024. It is now read-only.
Fixed positioning bug where MMPopLabel would not work for UIBarButtonIte...#10
Open
pajai wants to merge 1 commit intomgcm:masterfrom
Open
Fixed positioning bug where MMPopLabel would not work for UIBarButtonIte...#10pajai wants to merge 1 commit intomgcm:masterfrom
pajai wants to merge 1 commit intomgcm:masterfrom
Conversation
…Item within a navigation bar
|
It actually fixed the issue for me. Thanks @pajai, Really appreciate the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I did a change regarding the way the center position of the pop label is computed. Previously it did not work to show a pop label against a UIBarButtonItem if the latter was inside a navigation bar. With this change, the existing example is still working + if you add the pop label to 'self.navigationController.view' then you can get the pop label point at button item of the nav bar.
Kind regards.
Patrick