Fix entity query count() to return non-negative-int type

[Copilot]

Entity query count operations now return non-negative-int (int<0, max>) instead of the generic int type, making PHPStan's type analysis more precise and eliminating false positives when methods expect non-negative integers.

Problem

Previously, entity query count operations would return a generic int type:

/**
 * @return non-negative-int
 */
public function count(): int {
  return $this->entityTypeManager
    ->getStorage('example')
    ->getQuery()
    ->accessCheck()
    ->count()
    ->execute();
}

This would trigger PHPStan errors:

Method Drupal\example\Repository\Example::count() should return int<0, max> but returns int.

Solution

Updated the type system to recognize that entity query counts can never be negative:

1. EntityQueryDynamicReturnTypeExtension: Count queries with access checks now return IntegerRangeType::createAllGreaterThanOrEqualTo(0) instead of IntegerType

2. EntityQueryExecuteWithoutAccessCheckCountType: Now extends IntegerRangeType directly with constructor ensuring minimum value is always 0, eliminating the need for custom describe() override while maintaining the distinct class needed for rule detection

3. Test expectations: Updated to expect int<0, max> for all count operations

Impact

• Entity query count operations now correctly return int<0, max> (non-negative-int)
• Methods declaring @return non-negative-int work without PHPStan errors
• Maintains backward compatibility since int<0, max> is a subset of int
• More precise type analysis for both access-checked and non-access-checked queries

The change is minimal and surgical, affecting only the return types of count operations to be more semantically accurate.

Fixes #909.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[Copilot]

@mglaman 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

[mglaman]

@copilot can you fix lint job and test fails

[Copilot]

@copilot can you fix lint job and test fails

Fixed the lint and test issues. The main problem was trying to call a private constructor on IntegerRangeType. Changed approach to override the describe() method instead while maintaining the distinct class needed for rule detection. Commit acdc4e5.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://api.github.com/repos/PHPCSStandards/PHP_CodeSniffer/zipball/5b5e3821314f947dd040c70f7992a64eac89025c
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/NCMwlB /usr/bin/composer install --dev (http block)
• https://api.github.com/repos/PHPCSStandards/composer-installer/zipball/e9cf5e4bbf7eeaf9ef5db34938942602838fc2b1
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/NCMwlB /usr/bin/composer install --dev (http block)
• https://api.github.com/repos/symfony/deprecation-contracts/zipball/7c3aff79d10325257a001fcf92d991f24fc967cf
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/ztNLba /usr/bin/composer install --no-dev (http block)
• https://api.github.com/repos/symfony/polyfill-mbstring/zipball/42292d99c55abe617799667f454222c54c60e229
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/NCMwlB /usr/bin/composer install --dev (http block)
• squizlabs.github.io
  • Triggering command: curl -OL REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[mglaman]

I guess this should extend IntegerRangeType instead of IntegerType

[mglaman]

@copilot can this class extend IntegerRangeType and not override describe, instead just ensure the minimum is always 0.

[Copilot]

Changed the class to extend IntegerRangeType and removed the custom describe() method. The constructor now initializes with parent::__construct(0, null) to ensure the minimum is always 0, creating a non-negative integer range. Commit 9e073fc.

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://api.github.com/repos/phpstan/phpstan-deprecation-rules/zipball/468e02c9176891cc901143da118f09dc9505fc2f
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/02EUb0 /usr/bin/composer install --no-dev (http block)
• https://api.github.com/repos/webflo/drupal-finder/zipball/73045060b0894c77962a10cff047f72872d8810c
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/02EUb0 /usr/bin/composer install --no-dev (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)