Skip to content

Enable saving routing parameters in hbv_1_1p.py + Test in example/hydrology/dhbv_1_1p_zn_simu.ipynb#36

Open
ZhennanShi1 wants to merge 1 commit intomhpi:masterfrom
ZhennanShi1:zhennan-hbv-fix
Open

Enable saving routing parameters in hbv_1_1p.py + Test in example/hydrology/dhbv_1_1p_zn_simu.ipynb#36
ZhennanShi1 wants to merge 1 commit intomhpi:masterfrom
ZhennanShi1:zhennan-hbv-fix

Conversation

@ZhennanShi1
Copy link
Copy Markdown
Contributor

Issue Addressed

Description

  1. Adding following parameters in hbv1.1p class for supporting warm restart:

     self.routing_len = 15
     self.routing_state = None
     self._routing_state_cache = None
    
  2. Modified the get_states() and save_states() in hbv1.1p class to support the routing information stored in pt files

  3. save_states() and load_states() in ModleHanderler in dmg is modfied accordingly.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactor
  • Documentation update

Other (please specify):

Checklist

  • Branch is up to date with master
  • Updated tests or added new tests
  • Tests & pre-commit hooks pass
  • Updated documentation (if applicable)
  • Code follows established style and conventions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant